app/services/whatsapp/baileys_handlers/messages_update.rb:67

• update_last_seen_at now uses save!, which will update updated_at and run before_save/after_update_commit callbacks on Conversation. Elsewhere (e.g. ConversationsController) agent_last_seen_at updates intentionally use update_columns to avoid these side effects. Consider switching back to update_columns (with the existing rubocop disable) so receipt/read processing doesn’t create extra DB churn or trigger callbacks.

    conversation.agent_last_seen_at = Time.current
    conversation.assignee_last_seen_at = Time.current if conversation.assignee_id.present?
    conversation.save!

app/services/whatsapp/baileys_handlers/message_receipt_update.rb:28

• update_last_seen_at_from_receipt is only called after receipt_status_transition_allowed?. Because that method returns false when the message is already read, duplicate/late readTimestamp receipts will never update conversation.agent_last_seen_at/assignee_last_seen_at. In MessagesUpdate, last-seen timestamps are updated before the transition guard, so they still advance even when status doesn’t change. Consider updating last-seen timestamps based on the receipt payload before/independent of the status-transition check (while still preventing status downgrades).

  def handle_receipt_update
    return unless find_message_by_source_id(raw_message_id)

    new_status = receipt_status
    return if new_status.nil?
    return unless receipt_status_transition_allowed?(new_status)

    update_last_seen_at_from_receipt if incoming? && new_status == 'read'
    @message.update!(status: new_status)

app/services/whatsapp/baileys_handlers/message_receipt_update.rb:50

• update_last_seen_at_from_receipt uses conversation.save!, which will touch updated_at and run Conversation callbacks on every read receipt. Other parts of the codebase update last-seen fields via update_columns to avoid callbacks/timestamp churn. Consider using update_columns(agent_last_seen_at: ..., assignee_last_seen_at: ...) here as well (with the rubocop disable) to keep receipt processing lightweight.

  def update_last_seen_at_from_receipt
    conversation = @message.conversation
    conversation.agent_last_seen_at = Time.current
    conversation.assignee_last_seen_at = Time.current if conversation.assignee_id.present?
    conversation.save!

app/services/whatsapp/baileys_handlers/message_receipt_update.rb (1)

46-50: Consider extracting shared last-seen updater to avoid logic drift.

This block duplicates update_last_seen_at from app/services/whatsapp/baileys_handlers/messages_update.rb and can diverge over time.

♻️ Suggested refactor

# app/services/whatsapp/baileys_handlers/helpers.rb (or a shared concern)
+def update_conversation_last_seen!(conversation)
+  now = Time.current
+  conversation.agent_last_seen_at = now
+  conversation.assignee_last_seen_at = now if conversation.assignee_id.present?
+  conversation.save!
+end

# app/services/whatsapp/baileys_handlers/message_receipt_update.rb
 def update_last_seen_at_from_receipt
-  conversation = `@message.conversation`
-  conversation.agent_last_seen_at = Time.current
-  conversation.assignee_last_seen_at = Time.current if conversation.assignee_id.present?
-  conversation.save!
+  update_conversation_last_seen!(`@message.conversation`)
 end

# app/services/whatsapp/baileys_handlers/messages_update.rb
 def update_last_seen_at
-  conversation = `@message.conversation`
-  conversation.agent_last_seen_at = Time.current
-  conversation.assignee_last_seen_at = Time.current if conversation.assignee_id.present?
-  conversation.save!
+  update_conversation_last_seen!(`@message.conversation`)
 end

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/services/whatsapp/baileys_handlers/message_receipt_update.rb` around
lines 46 - 50, The two handlers duplicate last-seen update logic
(update_last_seen_at_from_receipt in
app/services/whatsapp/baileys_handlers/message_receipt_update.rb and
update_last_seen_at in
app/services/whatsapp/baileys_handlers/messages_update.rb); extract the shared
behavior into a single helper method (e.g., Conversation#touch_last_seen!, or a
small module/class LastSeenUpdater.call(conversation)) that sets
agent_last_seen_at = Time.current and only sets assignee_last_seen_at when
conversation.assignee_id.present?, then replace both
update_last_seen_at_from_receipt and update_last_seen_at to call that new
helper; ensure you preserve bang-save semantics (save! or equivalent) and
run/update tests that reference either original methods.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro